Feat/consolidate cast convert #12638
Open
+475
−421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dipanshuhappy
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
…eat/consolidate-cast-convert
grandizzy
requested changes
Nov 25, 2025
Collaborator
grandizzy
left a comment
grandizzy
left a comment
There was a problem hiding this comment.
thank you will need to fix tests to move forward
Contributor
Author
Updated |
grandizzy
approved these changes
Nov 29, 2025
Collaborator
grandizzy
left a comment
grandizzy
left a comment
There was a problem hiding this comment.
nice, ty, that's much cleaner. pending other reviewers as this is a breaking change and need consensus.
Contributor
|
@dipanshuhappy appreciate the work ser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #12500
Solution
Create a new file
convert.rswhich encapsulates all the sub commands mentioned.PR Checklist
NOTE: This does break existing cli commands related to conversation. Refer to the issue to know more about the cli commands that will break.